Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace Icon and Spinner with UI Kit variants #2386

Merged
merged 9 commits into from
Apr 29, 2024
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Apr 28, 2024

Summary

closes: #2376

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi requested a review from jeeanribeiro April 28, 2024 15:20
@Tuditi Tuditi self-assigned this Apr 28, 2024
@Tuditi Tuditi linked an issue Apr 28, 2024 that may be closed by this pull request
@Tuditi Tuditi marked this pull request as ready for review April 28, 2024 15:27
@Tuditi Tuditi changed the title 2376 icon chore: replace Icon and Spinner with UI Kit variants Apr 28, 2024
@MarkNerdi MarkNerdi enabled auto-merge (squash) April 29, 2024 08:24
@MarkNerdi MarkNerdi merged commit fca1423 into develop Apr 29, 2024
6 checks passed
@MarkNerdi MarkNerdi deleted the 2376-icon branch April 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Icon by bloom-ui component
2 participants