Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move network health into class #2379

Merged
merged 12 commits into from
Apr 29, 2024
Merged

chore: move network health into class #2379

merged 12 commits into from
Apr 29, 2024

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Apr 26, 2024

Summary

closes: #2362

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi linked an issue Apr 26, 2024 that may be closed by this pull request
Move polling of the network health and status inside the respective classes. #2362
Closed
@Tuditi Tuditi marked this pull request as ready for review April 26, 2024 21:18
@Tuditi Tuditi marked this pull request as draft April 29, 2024 08:04
@Tuditi Tuditi marked this pull request as ready for review April 29, 2024 08:04
@MarkNerdi MarkNerdi enabled auto-merge (squash) April 29, 2024 08:34
@MarkNerdi MarkNerdi merged commit 17f51ef into develop Apr 29, 2024
6 checks passed
@MarkNerdi MarkNerdi deleted the 2362-move-polling-of-the-network-health-and-status-inside-the-respective-classes branch April 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi MarkNerdi MarkNerdi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

Assignees

@MarkNerdi MarkNerdi

@Tuditi Tuditi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move polling of the network health and status inside the respective classes.
2 participants
@Tuditi @MarkNerdi