Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nest IscChains in StardusNetwork #2375

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Apr 25, 2024

Summary

Nests the actual IscChains instead of the configuration data.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Apr 25, 2024
@Tuditi Tuditi linked an issue Apr 25, 2024 that may be closed by this pull request
@Tuditi Tuditi marked this pull request as ready for review April 25, 2024 09:30
@Tuditi Tuditi requested a review from MarkNerdi April 26, 2024 07:36
@MarkNerdi MarkNerdi enabled auto-merge (squash) April 26, 2024 11:56
@MarkNerdi MarkNerdi merged commit 6cb2343 into develop Apr 26, 2024
5 checks passed
@MarkNerdi MarkNerdi deleted the 2374-nest-isc-chains-in-stardust-class branch April 26, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nest ISC chains in Stardust class
2 participants