Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: persisted tokens #2368

Merged
merged 35 commits into from
Apr 30, 2024
Merged

refactor: persisted tokens #2368

merged 35 commits into from
Apr 30, 2024

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this Apr 24, 2024
@MarkNerdi MarkNerdi marked this pull request as ready for review April 27, 2024 11:55
Tuditi
Tuditi suggested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with the base token now. The name and balance doesn't show up correctly:

on develop:
image

on this branch:
image

packages/shared/src/lib/core/token/stores/persisted-tokens.store.ts Outdated Show resolved Hide resolved
packages/shared/src/lib/core/activity/utils/outputs/getFormattedAmountFromActivity.ts Outdated Show resolved Hide resolved
packages/shared/src/lib/core/network/classes/evm-network.class.ts Show resolved Hide resolved
Tuditi
Tuditi suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unverify token doesn't work, but it doesn't work on develop either, so I will open an issue about it.

@Tuditi Tuditi enabled auto-merge (squash) April 30, 2024 08:42
Tuditi
Tuditi approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi merged commit 66c07d0 into develop Apr 30, 2024
6 checks passed
@Tuditi Tuditi deleted the refactor/refactor-persisted-tokens branch April 30, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

Assignees

@MarkNerdi MarkNerdi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkNerdi @Tuditi