Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement eth sendrawtransaction handler #1994

Merged
merged 16 commits into from
Feb 29, 2024

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this Feb 26, 2024
@MarkNerdi MarkNerdi marked this pull request as ready for review February 26, 2024 14:17
@MarkNerdi MarkNerdi requested review from Tuditi and removed request for cvarley100 and nicole-obrien February 26, 2024 14:17
@Tuditi Tuditi linked an issue Feb 26, 2024 that may be closed by this pull request
@MarkNerdi MarkNerdi enabled auto-merge (squash) February 28, 2024 09:21
Tuditi
Tuditi previously approved these changes Feb 29, 2024
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarkNerdi MarkNerdi merged commit 0952d3e into develop Feb 29, 2024
4 checks passed
@MarkNerdi MarkNerdi deleted the 1546----implement-eth_sendrawtransaction-handler branch February 29, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Implement eth_sendRawTransaction handler
2 participants