Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always show correct value and unit #1989

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Feb 23, 2024

Summary

Fixes the issues when unit is not correctly shown.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Feb 23, 2024
@MarkNerdi MarkNerdi requested review from MarkNerdi and removed request for cvarley100 and nicole-obrien February 26, 2024 10:30
@MarkNerdi MarkNerdi enabled auto-merge (squash) February 26, 2024 12:51
@MarkNerdi MarkNerdi merged commit 235e113 into develop Feb 26, 2024
4 checks passed
@MarkNerdi MarkNerdi deleted the fix/no-unit-if-0-balance branch February 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants