Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: contractaddress into alert #1981

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this Feb 22, 2024
@MarkNerdi MarkNerdi linked an issue Feb 22, 2024 that may be closed by this pull request
@MarkNerdi MarkNerdi requested review from Tuditi and removed request for nicole-obrien and cvarley100 February 22, 2024 15:14
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi enabled auto-merge (squash) February 22, 2024 15:47
@Tuditi Tuditi marked this pull request as draft February 22, 2024 15:47
auto-merge was automatically disabled February 22, 2024 15:47

Pull request was converted to draft

@Tuditi Tuditi marked this pull request as ready for review February 22, 2024 15:47
@MarkNerdi MarkNerdi merged commit 4d50460 into develop Feb 22, 2024
4 checks passed
@MarkNerdi MarkNerdi deleted the 1573----move-contractaddress-into-alert branch February 22, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Move contractAddress into Alert
2 participants