Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rebrand MarkdownBlock #1973

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Conversation

jeeanribeiro
Copy link
Member

Summary

closes #1915
depends on https://github.com/bloomwalletio/bloom-ui/pull/293

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this Feb 20, 2024
@jeeanribeiro jeeanribeiro linked an issue Feb 20, 2024 that may be closed by this pull request
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to build
Screenshot 2024-02-21 at 08 02 18

@jeeanribeiro
Copy link
Member Author

Unable to build Screenshot 2024-02-21 at 08 02 18

I reverted the patch removal and it fixed it

@jeeanribeiro jeeanribeiro enabled auto-merge (squash) February 21, 2024 12:42
Tuditi
Tuditi previously requested changes Feb 21, 2024
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link opens directly when it is rendered. See video:
Screencast from 2024-02-21 19:14:11.webm

@nicole-obrien nicole-obrien dismissed Tuditi’s stale review February 21, 2024 22:40

unable to reproduce, after updating ui kit?

@jeeanribeiro jeeanribeiro merged commit 4cfb541 into develop Feb 21, 2024
4 checks passed
@jeeanribeiro jeeanribeiro deleted the 1915-rebrand-markdownblock branch February 21, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 - Rebrand MarkdownBlock
3 participants