Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rebrand ProposalAnswer #1972

Merged
merged 4 commits into from
Feb 21, 2024
Merged

refactor: rebrand ProposalAnswer #1972

merged 4 commits into from
Feb 21, 2024

Conversation

jeeanribeiro
Copy link
Member

@jeeanribeiro jeeanribeiro commented Feb 20, 2024 •
edited
Loading

Summary

closes #1918

depends on https://github.com/bloomwalletio/bloom-ui/pull/292

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this Feb 20, 2024
@jeeanribeiro jeeanribeiro linked an issue Feb 20, 2024 that may be closed by this pull request
🛠 - Rebrand ProposalAnswer #1918
Closed
@jeeanribeiro jeeanribeiro force-pushed the 1918-rebrand-proposalanswer branch from 02ee8c2 to 2ec7428 Compare February 20, 2024 20:36
@jeeanribeiro jeeanribeiro force-pushed the 1918-rebrand-proposalanswer branch from 2ec7428 to 8dae931 Compare February 20, 2024 20:40
@Tuditi Tuditi enabled auto-merge (squash) February 21, 2024 12:31
Tuditi
Tuditi approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi merged commit 34b0902 into develop Feb 21, 2024
4 checks passed
@Tuditi Tuditi deleted the 1918-rebrand-proposalanswer branch February 21, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

Assignees

@jeeanribeiro jeeanribeiro

Labels
type:refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠 - Rebrand ProposalAnswer
2 participants
@jeeanribeiro @Tuditi