-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: polish SIWE ui #1964
Merged
MarkNerdi
merged 14 commits into
develop
from
1938----add-collapsible-details-to-siwe-popup
Feb 26, 2024
Merged
ui: polish SIWE ui #1964
MarkNerdi
merged 14 commits into
develop
from
1938----add-collapsible-details-to-siwe-popup
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkNerdi
force-pushed
the
1938----add-collapsible-details-to-siwe-popup
branch
from
February 20, 2024 10:15
9524767
to
07dc62e
Compare
nicole-obrien
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed for SIWE that we need to clean up ui how we show the data perhaps with tabs to stick to standard:
Title: Sign in with Ethereum
Statement:
Tabs:
- ???
- Scheme �+ Domain
- Network (chain)
- Account (address)
- Resources
- 1 row per uri
- Raw
- JSON object or string?
…add-collapsible-details-to-siwe-popup
…add-collapsible-details-to-siwe-popup
We just need to give the popup a max height, when on the raw tab it grows too large |
…add-collapsible-details-to-siwe-popup
nicole-obrien
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Testing
Platforms
Instructions
...
Checklist