Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: polish SIWE ui #1964

Merged
merged 14 commits into from
Feb 26, 2024
Merged

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this Feb 19, 2024
@jeeanribeiro jeeanribeiro linked an issue Feb 19, 2024 that may be closed by this pull request
@MarkNerdi MarkNerdi force-pushed the 1938----add-collapsible-details-to-siwe-popup branch from 9524767 to 07dc62e Compare February 20, 2024 10:15
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed for SIWE that we need to clean up ui how we show the data perhaps with tabs to stick to standard:

Title: Sign in with Ethereum
Statement:
Tabs:

  • ???
    • Scheme �+ Domain
    • Network (chain)
    • Account (address)
  • Resources
    • 1 row per uri
  • Raw
    • JSON object or string?

@nicole-obrien nicole-obrien changed the title ui: add collapsible table ui: polish SIWE ui Feb 20, 2024
@MarkNerdi MarkNerdi enabled auto-merge (squash) February 22, 2024 12:58
@nicole-obrien
Copy link
Contributor

We just need to give the popup a max height, when on the raw tab it grows too large

@MarkNerdi MarkNerdi merged commit 9bdd184 into develop Feb 26, 2024
4 checks passed
@MarkNerdi MarkNerdi deleted the 1938----add-collapsible-details-to-siwe-popup branch February 26, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

️🛠 - Add collapsible details to SIWE popup
2 participants