Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: outdated node on build #1961

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Feb 19, 2024

Summary

With the recent inclusion of @metamask-util, the build flow was broken. This has been fixed by updating the node version on the build file.

Also adds the option to run test builds manually.

Failing build here: https://github.com/bloomwalletio/bloom/actions/runs/7945086787
Successful ubuntu build here: https://github.com/bloomwalletio/bloom/actions/runs/7957639362

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@nicole-obrien nicole-obrien enabled auto-merge (squash) February 19, 2024 10:55
@nicole-obrien nicole-obrien merged commit 5eab4c2 into develop Feb 19, 2024
4 checks passed
@nicole-obrien nicole-obrien deleted the fix/outdated-node-on-build branch February 19, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants