Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ledger popups on send flow #1960

Merged
merged 17 commits into from
Feb 21, 2024
Merged

Conversation

MarkNerdi
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi MarkNerdi self-assigned this Feb 19, 2024
@MarkNerdi MarkNerdi requested a review from Tuditi February 19, 2024 09:20
@MarkNerdi MarkNerdi marked this pull request as ready for review February 19, 2024 09:20
@MarkNerdi MarkNerdi force-pushed the fix/fix-ledger-popup-on-send branch from 921430b to 4ba8165 Compare February 19, 2024 10:57
@MarkNerdi MarkNerdi force-pushed the fix/fix-ledger-popup-on-send branch from 4ba8165 to f53a048 Compare February 20, 2024 09:51
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three comments:

  • Should we replace checkOrConnectLedger with checkOrConnectLedgerAsync everywhere?
  • Cancelling opens two notifications:

image

  • Happy flow doesn't close the Verify Message Signing pop-up.
    image

Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi marked this pull request as draft February 21, 2024 12:38
@Tuditi Tuditi marked this pull request as ready for review February 21, 2024 12:39
@MarkNerdi MarkNerdi enabled auto-merge (squash) February 21, 2024 13:30
@Tuditi Tuditi marked this pull request as draft February 21, 2024 14:17
auto-merge was automatically disabled February 21, 2024 14:17

Pull request was converted to draft

@Tuditi Tuditi marked this pull request as ready for review February 21, 2024 14:17
@MarkNerdi MarkNerdi merged commit 38dab89 into develop Feb 21, 2024
4 checks passed
@MarkNerdi MarkNerdi deleted the fix/fix-ledger-popup-on-send branch February 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants