Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update tailwindcss & cleanup safelist #1887

Merged
merged 23 commits into from
Feb 20, 2024

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Feb 6, 2024

Summary

The update to tailwindcss 3.4.1 requires a clean-up of the safe list. Otherwise the following error is thrown:

Module build failed (from ../../node_modules/svelte-loader/index.js):
Error: RangeError: RangeError: Maximum call stack size exceeded
    at /home/tuditi/bloom-labs/bloom/node_modules/svelte-loader/index.js:142:12

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi marked this pull request as ready for review February 7, 2024 13:00
@Tuditi Tuditi marked this pull request as draft February 8, 2024 12:35
@jeeanribeiro jeeanribeiro self-assigned this Feb 8, 2024
@Tuditi Tuditi force-pushed the fix/tailwindcss-maximum-call-size branch from e28c8ea to f5f9669 Compare February 12, 2024 13:53
@Tuditi Tuditi marked this pull request as ready for review February 12, 2024 15:25
@Tuditi Tuditi marked this pull request as draft February 12, 2024 15:36
@Tuditi Tuditi marked this pull request as ready for review February 12, 2024 15:37
@nicole-obrien nicole-obrien enabled auto-merge (squash) February 20, 2024 09:33
@nicole-obrien nicole-obrien merged commit 2dc3917 into develop Feb 20, 2024
4 checks passed
@nicole-obrien nicole-obrien deleted the fix/tailwindcss-maximum-call-size branch February 20, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants