Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent Transak window from showing on top of popups #1720

Merged
merged 3 commits into from
Jan 19, 2024
Merged

fix: prevent Transak window from showing on top of popups #1720

merged 3 commits into from
Jan 19, 2024

Conversation

jeeanribeiro
Copy link
Member

Summary

closes #1710

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this Jan 18, 2024
@jeeanribeiro jeeanribeiro linked an issue Jan 18, 2024 that may be closed by this pull request
️🛠 - Prevent Transak window from showing on top of popups and dialogs #1710
Closed
@Tuditi Tuditi enabled auto-merge (squash) January 19, 2024 13:40
Tuditi
Tuditi approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@Tuditi Tuditi merged commit 1a5deb0 into develop Jan 19, 2024
4 checks passed
@Tuditi Tuditi deleted the 1710-prevent-transak-window-from-showing-on-top-of-popups-and-dialogs branch January 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

Assignees

@jeeanribeiro jeeanribeiro

Labels
type:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

️🛠 - Prevent Transak window from showing on top of popups and dialogs
2 participants
@jeeanribeiro @Tuditi