Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: rebrand Ledger connection guide #1237

Merged
merged 10 commits into from
Oct 30, 2023
Merged

enhancement: rebrand Ledger connection guide #1237

merged 10 commits into from
Oct 30, 2023

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Oct 26, 2023 •
edited
Loading

Summary

Please summarize your changes, describing what they are and why they were made.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan linked an issue Oct 26, 2023 that may be closed by this pull request
️🛠 - Rebrand LedgerConnectionGuidePopup #1010
Closed
@maxwellmattryan maxwellmattryan self-assigned this Oct 26, 2023
@maxwellmattryan maxwellmattryan marked this pull request as draft October 26, 2023 19:30
@maxwellmattryan maxwellmattryan marked this pull request as ready for review October 26, 2023 20:28
@Tuditi Tuditi requested review from Tuditi and removed request for cvarley100 and nicole-obrien October 27, 2023 11:49
Tuditi
Tuditi suggested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. Functionality is great though.

packages/desktop/components/popup/Popup.svelte Show resolved Hide resolved
packages/desktop/components/popup/popups/LedgerConnectionGuidePopup.svelte Show resolved Hide resolved
packages/desktop/views/onboarding/views/create-from-ledger/create-from-ledger-route.enum.ts Outdated Show resolved Hide resolved
packages/desktop/views/onboarding/views/create-from-ledger/views/index.js Outdated Show resolved Hide resolved
packages/shared/src/components/atoms/LedgerIllustration.svelte Outdated Show resolved Hide resolved
...ding/views/create-from-ledger/views/ledger-connection-guide/LedgerConnectionGuideView.svelte Outdated Show resolved Hide resolved
...ding/views/create-from-ledger/views/ledger-connection-guide/LedgerConnectionGuideView.svelte Outdated Show resolved Hide resolved
...ding/views/create-from-ledger/views/ledger-connection-guide/LedgerConnectionGuideView.svelte Outdated Show resolved Hide resolved
...rding/views/create-from-ledger/views/ledger-connection-guide/components/LedgerAppOpen.svelte Outdated Show resolved Hide resolved
...rding/views/create-from-ledger/views/ledger-connection-guide/components/LedgerAppOpen.svelte Outdated Show resolved Hide resolved
@Tuditi Tuditi enabled auto-merge (squash) October 30, 2023 07:58
Tuditi
Tuditi approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous PR changed the pixel width of the illustration. This made it difficult to reuse, so I replaced it with w-full so it adheres to the designs.

Nice work! 💪

@Tuditi Tuditi merged commit bc063a7 into develop Oct 30, 2023
4 checks passed
@Tuditi Tuditi deleted the 1010-rebrand-ledgerconnectionguidepopup branch October 30, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

Assignees

@maxwellmattryan maxwellmattryan

Labels
scope:ledger type:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

️🛠 - Rebrand LedgerConnectionGuidePopup
2 participants
@maxwellmattryan @Tuditi