Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: adjust FormattedBalance font size depending on available space #1181

Merged
merged 10 commits into from
Oct 25, 2023
Merged

enhancement: adjust FormattedBalance font size depending on available space #1181

merged 10 commits into from
Oct 25, 2023

Conversation

jeeanribeiro
Copy link
Member

Summary

#1115

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro self-assigned this Oct 20, 2023
@jeeanribeiro jeeanribeiro linked an issue Oct 20, 2023 that may be closed by this pull request
🐞 - Currency is cut off in the Account Summary #1115
Closed
@jeeanribeiro jeeanribeiro enabled auto-merge (squash) October 20, 2023 03:02
Tuditi
Tuditi previously requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks weird if there is a balance difference between Shimmer EVM & Shimmer.

image

packages/desktop/components/FormattedBalance.svelte Outdated Show resolved Hide resolved
@jeeanribeiro jeeanribeiro requested a review from Tuditi October 20, 2023 20:26
@jeeanribeiro jeeanribeiro changed the title enhancement: adjust FormattedBalance text type depending on available space enhancement: adjust FormattedBalance font size depending on available space Oct 23, 2023
@MarkNerdi
Merge commit '0b13f6b992db1fdf15ca2e595ea44b218577807d' into 1115-lad…
ae9288f 
…y_beetle-currency-is-cut-off-in-the-account-summary
MarkNerdi
MarkNerdi previously approved these changes Oct 24, 2023
View reviewed changes
MarkNerdi
MarkNerdi previously approved these changes Oct 24, 2023
View reviewed changes
@jeeanribeiro jeeanribeiro merged commit 4ae9d1d into develop Oct 25, 2023
4 checks passed
@jeeanribeiro jeeanribeiro deleted the 1115-lady_beetle-currency-is-cut-off-in-the-account-summary branch October 25, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi MarkNerdi MarkNerdi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100 cvarley100 is a code owner

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien nicole-obrien is a code owner

@Tuditi Tuditi Awaiting requested review from Tuditi

Assignees

@jeeanribeiro jeeanribeiro

Labels
context:wallet type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Currency is cut off in the Account Summary
3 participants
@jeeanribeiro @MarkNerdi @Tuditi