Kyle Baker #485

kybak · 2019-02-13T02:08:25Z

KingAtoki · 2019-02-22T04:22:26Z

Make sure to .gitignore those node_modules and then take them out of github!

KingAtoki · 2019-02-22T04:26:16Z

data/helpers/noteModel.js

+    return db('notes')
+      .where('id', id)
+      .update(changes)
+      .then(count => (count > 0 ? this.get(id) : null));


You don't have to have the > 0

KingAtoki · 2019-02-22T04:28:12Z

api/auth.js

+    const saltRounds = 10;
+
+    if (!user_name || !email || !password || !name) {
+      console.log('Missing information');


Make sure to remove the console.log statements when commiting

Suggested change

console.log('Missing information');

KingAtoki · 2019-02-22T04:28:22Z

api/auth.js

+      return res.status(400).json({ error: "Missing information" });
+    }
+
+    console.log('Registering');


Suggested change

console.log('Registering');

KingAtoki · 2019-02-22T04:29:24Z

api/auth.js

+
+    console.log('Registering');
+
+    req.body.password = await bcrypt.hash(password, saltRounds).then(hash => hash);


For this .then(hash => hash); if you are just returning what you are getting, do you even need it?

Kyle Baker and others added 11 commits February 12, 2019 18:07

added trello link to readme

85ceedb

bootstrapped

06a46fa

data model

9640085

note helpers

76da544

routes

6babb4c

gitignore

ccd8c6d

tag helper bugs

914478c

authentication

5f8aadc

authentication

d2a55ba

seeding

fbf88d3

minor changes

2cd1374

KingAtoki reviewed Feb 22, 2019

View reviewed changes

Provide feedback


		console.log('Registering');

		req.body.password = await bcrypt.hash(password, saltRounds).then(hash => hash);