Sprint Web Server: Kat Johnson-Fries #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tulf
reviewed
Mar 16, 2019
src/client.c
Outdated
| path = forward_slash + 1; | ||
| *forward_slash = '\0'; | ||
|
|
||
| colon = strchr(hostname, '/'); |
src/client.c
Outdated
| urlinfo->hostname = hostname; | ||
| urlinfo->port = port; | ||
| urlinfo->path = path; | ||
| return urlinfo; |
src/client.c
Outdated
| return 0; | ||
| // ``` | ||
|
|
||
| int request_length = snprintf(request, max_request_size, |
There was a problem hiding this comment.
Looks like you're request is connecting properly
src/client.c
Outdated
| } | ||
|
|
||
| free(urlinfo->hostname); | ||
| free(urlinfo->port); |
There was a problem hiding this comment.
You don't need to free these since you didn't malloc them.
| free(urlinfo->hostname); | ||
| free(urlinfo->port); | ||
| free(urlinfo->path); | ||
| free(urlinfo); |
|
I tried fixing parts of your code and running it but even looking at my old repo and the solution I kept getting a segfault. Not sure why but you had many silly errors because of the amounts of comments you left in this code. It seems like you were really close though. |
|
I fixed the colon thing but didn’t push after that. I think it comes from trying things one way and then another and then another and not getting it to pass. I need to stop copying and pasting similar lines since I end up not completely changing the next. I could not figure out how to printf to see the responses.
…Sent from my iPhone
On Mar 15, 2019, at 9:15 PM, Tulf ***@***.***> wrote:
I tried fixing parts of your code and running it but even looking at my old repo and the solution I kept getting a segfault. Not sure why but you had many silly errors because of the amounts of comments you left in this code. It seems like you were really close though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tulf