-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LambdaMUD - Wonjae Hwang, PM Adrian Adames #127
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonjae, this code looks great! If you haven't already I hope you will go back and implement the say command as well as any other goals, MVP, Stretch or otherwise. Overall though, Good job!
@@ -1,3 +1,7 @@ | |||
# Trello Link | |||
|
|||
https://trello.com/b/6FZkyg66/lambdamud-wonjae-hwang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that you added your trello link here, it's a small thing but many students forget and it's important for documenting your code.
@@ -96,6 +96,9 @@ | |||
} | |||
} | |||
|
|||
db_from_env = dj_database_url.config(conn_max_age=500) | |||
DATABASES['default'].update(db_from_env) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting syntax. It may be the first time I've seen it so far but it's very semantic which is good!
Trello Link - https://trello.com/b/6FZkyg66/lambdamud-wonjae-hwang
Trello Set Up:
backlog
,To Do
,In Progress
, andDone
To Do
list with the MVP features listed belowbacklog
list with all the extra features listed belowMVP Features:
Client
say
command to say things that other people in the room will see (server implementation incomplete)p-channel-<uuid>
broadcast
events and display the messages to the playerServer
say
which broadcasts a message to other players in the current roomGeneral