-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huthman King: LambdaMUD #124
base: master
Are you sure you want to change the base?
Huthman King: LambdaMUD #124
Conversation
Installed Dependencies Added trello link Added migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
Huthman. Your overall code base looks clean and well written. Your workflow is fluid and you have really done a good job of decomposition in this project. You have shown an understanding of the subject matter and implemented the overall project in a clean manner. You have also deployed the projects back and front end.
Breakdown
- You have got MVP complete and then some.
- your work is of good quality and you have really made this lambdaMUD your own.
- You have added links in to the deployments
- kept your commits clean and your git workflow granular and regular
Conclusions
Huthman. You have shown a good grasp of the material for this sprint and it has been a pleasure to install it locally and do a review over it. The only thing that I did not have was the login details to the API and deployed stuff. I also had to use my own API and secret keys etc to test it locally. that in itself if not a bad thing but it added a layer of complexity to the review. but Keep up the good work Huthman 👍
No description provided.