Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rileyB-web-server #308

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

rileyB-web-server #308

wants to merge 7 commits into from

Conversation

Riley-Brown
Copy link

Tulf
Tulf reviewed Mar 13, 2019
View reviewed changes
src/cache.c Outdated
@@ -12,6 +12,13 @@ struct cache_entry *alloc_entry(char *path, char *content_type, void *content, i
///////////////////
// IMPLEMENT ME! //
///////////////////
struct cache_entry *new_entry = malloc(sizeof(struct cache_entry));
new_entry->path = path;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will run into some seg faults if you don't strcpy/memcpy some of these variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tulf Tulf Tulf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Riley-Brown @Tulf