fix: use exit code

Signed-off-by: Marty Jones <[email protected]>
bloomberg · Dec 19, 2024 · 4230795 · 4230795
1 parent 4190189
commit 4230795
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/src/context.ts b/packages/core/src/context.ts
@@ -46,9 +46,9 @@ export interface StricliProcess extends WritableStreams {
      */
     readonly env?: Readonly<Partial<Record<string, string>>>;
     /**
-     * Set the exit code and end the current process.
+     * A number which will be the process exit code.
      */
-    readonly exit?: (code: number) => void;
+    exitCode?: number | string;
 }
 
 /**

diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -76,5 +76,8 @@ export async function run<CONTEXT extends CommandContext>(
     context: StricliDynamicCommandContext<CONTEXT>,
 ): Promise<void> {
     const exitCode = await runApplication(app, inputs, context);
-    context.process.exit?.(exitCode);
+
+    // We set the exit code instead of calling exit() so as not
+    // to cancel any pending tasks (e.g. stdout writes)
+    context.process.exitCode = exitCode;
 }
diff --git a/packages/core/tests/application.spec.ts b/packages/core/tests/application.spec.ts
@@ -94,7 +94,7 @@ function buildBasicRouteMap(brief: string) {
 interface ApplicationRunResult {
     readonly stdout: string;
     readonly stderr: string;
-    readonly exitCode: number | undefined;
+    readonly exitCode: number | string | undefined;
 }
 
 async function runWithInputs(
@@ -111,7 +111,7 @@ async function runWithInputs(
     };
 }
 
-function serializeExitCode(exitCode: number | undefined): string {
+function serializeExitCode(exitCode: number | string | undefined): string {
     const knownExitCode = Object.entries(ExitCode).find(([_, value]) => value === exitCode);
     if (knownExitCode) {
         return knownExitCode[0];

diff --git a/packages/core/tests/fakes/context.ts b/packages/core/tests/fakes/context.ts
@@ -16,7 +16,6 @@ interface FakeProcess extends StricliProcess {
     readonly stdout: FakeWritable;
     readonly stderr: FakeWritable;
     readonly exit: (code: number) => void;
-    readonly exitCode: number;
 }
 
 export type FakeContext = StricliDynamicCommandContext<CommandContext> & {
@@ -60,9 +59,6 @@ export function buildFakeContext(options: FakeContextOptions = { forCommand: tru
             exit: (code) => {
                 exitCode = code;
             },
-            get exitCode() {
-                return exitCode;
-            },
         },
         locale: options.locale,
     };