Fix bug with Cython and make CI run daily #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahmonod
force-pushed
the
fix-pxd
branch
2 times, most recently
from
19bbff3 to
46a79b6
Compare
It shouldn't have been here to begin with, and with newer versions of Cython this is now an error. Running CI daily would have helped us detect that issue earlier. This commit also drops CI for 2.7, 3.6, and 3.7, in preparation for a next version that will no longer support these versions. Signed-off-by: Gus Monod <[email protected]>
Signed-off-by: Gus Monod <[email protected]>
|
@godlygeek can you please remove 3.7 from the list of required checks and add 3.11 and 3.12 instead? Alternatively you can grant me access to that repo and I can do it. |
Done, with @michaelmoss's help! I'm going to land this, now that all tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.pxdsource files