Review Changes

Signed-off-by: asardesai2 <[email protected]>
bloomberg · Nov 27, 2023 · 106bbe2 · 106bbe2
1 parent 3957b37
commit 106bbe2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/comdb2/_ccdb2.pyx b/comdb2/_ccdb2.pyx
@@ -183,7 +183,7 @@ cdef class _ParameterValue(object):
                 elif all(isinstance(ele, bytes) for ele in obj):
                     self.type = lib.CDB2_BLOB
                     self.size = sizeof(blob_descriptor)
-                    self.owner = None
+                    self.owner = obj
                     self.data = PyMem_Malloc(self.list_size * self.size)
                     for l_index in range(self.list_size):
                         (<blob_descriptor*>self.data)[l_index].size = len(obj[l_index])

diff --git a/tests/test_dbapi2.py b/tests/test_dbapi2.py
@@ -900,6 +900,11 @@ def test_parameter_binding_arrays(values):
             "Can't bind tuple value (1j,) for parameter 'values': "
             + "ValueError: Cannot bind a tuple of complex",
         ),
+        (
+            ((1, 2, 3),),
+            "Can't bind tuple value ((1, 2, 3),) for parameter 'values': "
+            + "ValueError: Cannot bind a tuple of tuple",
+        ),
     ],
 )
 def test_parameter_binding_invalid_arrays(values, exc_msg):