Allow multi-line ';'-delimited cdb2sql statements #4938
+588
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgando
force-pushed
the
sql-tail
branch
4 times, most recently
from
8156d61 to
54ac0ba
Compare
roborivers
suggested changes
Dec 27, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
morgando
commented
Dec 27, 2024
|
|
||
| // Processes ddl statements as '$$' delimited blocks | ||
| // and all other statements as single lines. | ||
| class DdlBlockInputProcessor : public InputProcessor { |
There was a problem hiding this comment.
I don't like this name
morgando
force-pushed
the
sql-tail
branch
2 times, most recently
from
a194333 to
f423e7f
Compare
|
Looks good. Maybe a different prompt if the last statement was incomplete? Just a suggestion, works great without it. |
mponomar
previously approved these changes
Dec 30, 2024
morgando
force-pushed
the
sql-tail
branch
4 times, most recently
from
274378e to
19e1f70
Compare
Signed-off-by: Michael Ponomarenko <[email protected]>
morgando
force-pushed
the
sql-tail
branch
4 times, most recently
from
1342155 to
53e8652
Compare
Signed-off-by: Morgan Douglas <[email protected]> Add to refactor Signed-off-by: Morgan Douglas <[email protected]> Add to refactor Signed-off-by: Morgan Douglas <[email protected]> Add to refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> WIP completerbuf->std::string Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Use different prompt mid-stmt Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> WIP: Support ';' Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]> Tweak refactor Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]> Tweak tests Signed-off-by: Morgan Douglas <[email protected]>
roborivers
suggested changes
Jan 2, 2025
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 131/597 tests failed ⚠.
The first 10 failing tests are:
autoanalyze [setup failure]
logfill_logput_window_generated
phys_rep_perf
analyze_exit_immediately
snapisol_partial_index_off_generated
snapisol_noearly_generated
snap_ha_retry_newsi_generated
fdb_compat
ddl_csc2
simple_remsql_whitelist_generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tests for example use