Address flakiness in commit LSN map test #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Douglas <[email protected]>
roborivers
suggested changes
Sep 28, 2024
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 246/580 tests failed ⚠.
The first 10 failing tests are:
sc_resume
truncatesc_ufid_on_generated
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
auth_twofiles_generated
auth_queueodh_generated
auth
userschema_queueodh_generated
userschema
chands10
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been flake-y since it uses a sleep to wait for replicants to finish recovery before doing validations on them. The sleep has sometimes not been sufficient.
The changes in this PR just do validations on the master node. Since we're guaranteed that the master is done with recovery by the time the call to truncate returns there's no more need for client-end timing logic.
Alternatively a better waiting method could be used to detect that the replicants are finished with recovery before performing validations on them.