[8.0]{176316843}: Adding local-cache flag to clnt #4689
+37
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
suggested changes
Sep 15, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 10/556 tests failed ⚠.
The first 10 failing tests are:
autoanalyze [setup failure]
timepart_trunc_serialsc_generated
timepart_trunc
diskspace_nollmeta_nostripe_generated
diskspace_nollmeta
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
truncatesc
truncatesc_offline_generated
morgando
previously approved these changes
Sep 26, 2024
riverszhang89
force-pushed
the
local_cache_8
branch
from
922cd81
to
76fb927
Compare
These changes would help us identify whether a connection is truly leaked, or is being cached in the client process. Signed-off-by: Rivers Zhang <[email protected]>
riverszhang89
force-pushed
the
local_cache_8
branch
from
76fb927
to
f629304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes would help us identify whether a connection is truly leaked, or is being cached in the client process.