Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[bmq]: Flush output on test and contract failures #583

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

hallfox
Copy link
Collaborator

@hallfox hallfox commented Jan 23, 2025

We're seeing failures from tests without any of the context we'd expect (e.g. a bsls assertion failure without line number info). To fix, we should explicitly flush stdout/stderr depending on which mode we're failing in.

@hallfox hallfox added bug Something isn't working A-Testing Area: Testing labels Jan 23, 2025
@hallfox hallfox requested a review from a team as a code owner January 23, 2025 17:34
@hallfox hallfox force-pushed the stderr-asserttestfail branch from 1306b80 to 291c98b Compare January 23, 2025 17:35
@hallfox hallfox changed the title Flush output on test and contract failures Fix[bmq]: Flush output on test and contract failures Jan 23, 2025
@dorjesinpo
Copy link
Collaborator

test_shutdown_upstream_proxy[virtual_fsm] failure is irrelevant and can be ignored

mqbc_incoreclusterstateledger.t, failure is irrelevant. It is output proves the PR is working
Error /home/runner/work/blazingmq/blazingmq/src/groups/mqb/mqbc/mqbc_incoreclusterstateledger.t.cpp(110): 'cslIter.header().recordType()' (UPDATE) == 'recordType' (SNAPSHOT) (failed)

We get file, line, expression now!

Copy link
Collaborator

@dorjesinpo dorjesinpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dorjesinpo dorjesinpo merged commit c18ff5c into bloomberg:main Jan 23, 2025
25 of 31 checks passed
@hallfox hallfox deleted the stderr-asserttestfail branch January 23, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Testing Area: Testing bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants