Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc[mqbblp::ClusterQHelper]: Print queue info instead of pointer address #572

Merged
merged 1 commit into from
Jan 15, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4029,7 +4029,7 @@ void ClusterQueueHelper::onQueueAssigned(
// above

BALL_LOG_INFO << d_cluster_p->description()
<< ": Assigned queue: " << info;
<< ": Assigned queue: " << *info;

// Note: In non-CSL mode, the queue creation callback is instead invoked at
// replica nodes when they receive a queue creation record from the primary
Expand Down Expand Up @@ -4093,7 +4093,7 @@ void ClusterQueueHelper::onQueueUnassigned(
// unassignment advisory from the leader.
BALL_LOG_ERROR << d_cluster_p->description()
<< ": Ignoring queue unassignment from leader "
<< leaderDesc << ", for unknown queue: " << info;
<< leaderDesc << ", for unknown queue: " << *info;

BSLS_ASSERT_SAFE(0 ==
d_clusterState_p->queueKeys().count(info->key()));
Expand All @@ -4118,7 +4118,7 @@ void ClusterQueueHelper::onQueueUnassigned(

BALL_LOG_ERROR << d_cluster_p->description()
<< ": Ignoring queue unassignment from leader "
<< leaderDesc << ", for queue: " << info
<< leaderDesc << ", for queue: " << *info
<< " because self node sees queue as unassigned.";
return; // RETURN
}
Expand All @@ -4132,7 +4132,7 @@ void ClusterQueueHelper::onQueueUnassigned(

BALL_LOG_WARN << d_cluster_p->description()
<< ": Received queue unassignment from leader "
<< leaderDesc << ", for queue: " << info
<< leaderDesc << ", for queue: " << *info
<< " but num handle count is ["
<< qinfo.d_numQueueHandles << "].";
}
Expand Down Expand Up @@ -4170,7 +4170,7 @@ void ClusterQueueHelper::onQueueUnassigned(

BALL_LOG_INFO << d_cluster_p->description()
<< ": While processing queue assignment from leader "
<< leaderDesc << ", for queue: " << info
<< leaderDesc << ", for queue: " << *info
<< ", resetting queue info:"
<< " [in-flight contexts: " << qinfo.d_inFlight
<< ", pending contexts: " << qinfo.d_pending.size()
Expand All @@ -4191,7 +4191,7 @@ void ClusterQueueHelper::onQueueUnassigned(
else {
// Nothing is pending, it is safe to delete all references.
BALL_LOG_INFO << d_cluster_p->description()
<< ": All references to queue: " << info
<< ": All references to queue: " << *info
<< " removed.";

removeQueueRaw(queueContextIt);
Expand All @@ -4215,7 +4215,7 @@ void ClusterQueueHelper::onQueueUnassigned(
->adjustQueueCount(-1);

BALL_LOG_INFO << d_cluster_p->description()
<< ": Unassigned queue: " << info;
<< ": Unassigned queue: " << *info;
}

void ClusterQueueHelper::onQueueUpdated(const bmqt::Uri& uri,
Expand Down
Loading