Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs[mqbblp]: Complete conversion of mqbblp documentation from BDE style to Doxygen style #570

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

pniedzielski
Copy link
Collaborator

This continues the work started in PR #523 into the mqbblp package. It contains three independent patches:

  1. Make doxygen ignore BSLMF_NESTED_TRAIT_DECLARATION: Fixes several warnings during documentation generation.

  2. Convert mqbblp documentation to Doxygen format: Migrates in-code documentation to Doxygen format.

  3. Migrate mqbblp docs directory into a Doxygen file: Migrates package-level documentation to Doxygen format.

@pniedzielski pniedzielski added documentation Improvements or additions to documentation A-Docs Area: Documentation labels Jan 14, 2025
@pniedzielski pniedzielski requested a review from a team as a code owner January 14, 2025 23:07
@pniedzielski pniedzielski force-pushed the doxygen/mqbblp branch 2 times, most recently from 6bb6efb to dee6241 Compare January 14, 2025 23:12
hallfox
hallfox previously approved these changes Jan 14, 2025
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 443 of commit ab52bb0 has completed with FAILURE

Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 444 of commit 291986a has completed with FAILURE

emelialei88
emelialei88 approved these changes Jan 15, 2025
Copy link
Collaborator

@emelialei88 emelialei88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanitizer error

@pniedzielski
Copy link
Collaborator Author

pniedzielski commented Jan 16, 2025

Sanitizer error

This shouldn't be related to anything in this PR.
https://github.com/bloomberg/blazingmq/actions/runs/12792967796 main hasn't been running sanitizer builds either.

Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 447 of commit 0d3fb13 has completed with FAILURE

emelialei88
emelialei88 previously approved these changes Jan 16, 2025
This patch teaches Doxygen to ignore the
`BSLMF_NESTED_TRAIT_DECLARATION` macro instantiations in many of our
class declarations, which confuse its parser and cause warnings and
incorrect documentation generation.

Signed-off-by: Patrick M. Niedzielski <[email protected]>
This patch makes three changes:

  1. First, it converts the BDE-style component documentation into
     Doxygen `@file` documentation.

  2. Next, it converts stray BDE-style documentation that was not
     automatically converted to Doxygen format when we open-sourced.

  3. Finally, it makes minor changes to non-Doxygen comments, like file
     header comments or include comments, which were not correctly
     updated in the past.

This patch continues the work from commit a75a915.

Signed-off-by: Patrick M. Niedzielski <[email protected]>
This patch removes the old `doc/*.txt` file and migrates some
information in it into a file Doxygen can read.  The information not
migrated is:

  1. the table of contents for this package, which is very out-of-date and will
  be generated by Doxygen automatically, and kept in-sync with any
  documentation changes made in the files, and

  2. the hierarchical synopsis, which is also out-of-date.

This continues the changes made in commit cb037c6.

Signed-off-by: Patrick M. Niedzielski <[email protected]>
@pniedzielski pniedzielski merged commit 8c8af57 into bloomberg:main Jan 16, 2025
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Docs Area: Documentation documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants