Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move bmqtst globals into a helper struct #533

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

hallfox
Copy link
Collaborator

@hallfox hallfox commented Nov 27, 2024

This is causing some conflicting symbol definitions with users of the old mwctst package. This should only be affecting test files and implementations of components in bmqtst.

@hallfox hallfox requested a review from a team as a code owner November 27, 2024 18:30
@hallfox hallfox force-pushed the testhelper-refactor branch 2 times, most recently from 081e2fa to 41b1375 Compare November 27, 2024 18:31
@hallfox hallfox changed the title Move bqmtst globals into a helper struct [Refactor]: Move bmqtst globals into a helper struct Nov 27, 2024
@hallfox hallfox force-pushed the testhelper-refactor branch from 41b1375 to dd52e56 Compare November 27, 2024 18:32
@hallfox hallfox changed the title [Refactor]: Move bmqtst globals into a helper struct refactor: Move bmqtst globals into a helper struct Nov 27, 2024
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@hallfox hallfox merged commit e5c6105 into bloomberg:main Dec 2, 2024
29 of 31 checks passed
@hallfox hallfox deleted the testhelper-refactor branch December 2, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants