Feat[MQB]: Do not record last confirm #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpetukhov
force-pushed
the
do-not-record-last-confirm
branch
from
6d8e88a to
dccafc0
Compare
Signed-off-by: Dmitrii Petukhov <[email protected]>
Signed-off-by: Dmitrii Petukhov <[email protected]>
Signed-off-by: Dmitrii Petukhov <[email protected]>
bbpetukhov
force-pushed
the
do-not-record-last-confirm
branch
from
1f0b061 to
14c461b
Compare
678098
reviewed
Oct 8, 2024
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Dmitrii Petukhov <[email protected]>
Signed-off-by: Dmitrii Petukhov <[email protected]>
678098
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Misc comments.
Let's also fix warnings in the new test file from CI check UT [C++]
https://productionresultssa13.blob.core.windows.net/actions-results/85f085aa-bee4-4859-9ef1-8c0188f9cca1/workflow-job-run-63f2f093-663a-5fa9-4a2e-8878fefbc7e7/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-10-09T14%3A33%3A14Z&sig=%2BhV9s4XueHcYfci70aJVwz63O7TxrThtpwct2kiMON4%3D&ske=2024-10-09T23%3A27%3A43Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2024-10-09T11%3A27%3A43Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-08-04&sp=r&spr=https&sr=b&st=2024-10-09T14%3A23%3A09Z&sv=2024-08-04
Search for mqbs_filebackedstorage.t in UT build log.
Signed-off-by: Dmitrii Petukhov <[email protected]>
…h FileBackedStorage and InMemoryStorage Signed-off-by: Dmitrii Petukhov <[email protected]>
Signed-off-by: Dmitrii Petukhov <[email protected]>
bbpetukhov
force-pushed
the
do-not-record-last-confirm
branch
from
c3e9108 to
92d8f6c
Compare
678098
reviewed
Oct 14, 2024
678098
requested changes
Oct 14, 2024
…ucture in InMemoryStorage unit tests Signed-off-by: Dmitrii Petukhov <[email protected]>
Update comment on number of records Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Dmitrii Petukhov <[email protected]>
Fix typo in comment Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Dmitrii Petukhov <[email protected]>
…ucture Signed-off-by: Dmitrii Petukhov <[email protected]>
bbpetukhov
force-pushed
the
do-not-record-last-confirm
branch
from
93bc887 to
ca16e5f
Compare
Signed-off-by: Dmitrii Petukhov <[email protected]>
Signed-off-by: Dmitrii Petukhov <[email protected]>
Signed-off-by: Dmitrii Petukhov <[email protected]>
bbpetukhov
force-pushed
the
do-not-record-last-confirm
branch
from
9b64aef to
4cf7d27
Compare
678098
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The goal of this optimization is to avoid storing the last Confirm record in the journal file, because the Delete record follows right after this Confirm record, thus the last Confirm record is redundant.
Also since we'll have to store one record less, I decreased from 3 to 2 the default static size of records array.
Previously there were no unit tests for FileBackedStorage. Added 22 unit tests for FileBackedStorage by analogy to InMemoryStorage, since both classes inherit from ReplicatedStorage and their usage scenarios are similar.
Testing performed
Additional context
Priority mode:
Fanout mode: