Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix[bmqt_messageguid.h]: fix possible UB due to misalignment #423

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix[bmqt_messageguid.h]: fix possible UB due to misalignment #423

merged 2 commits into from
Sep 30, 2024

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Sep 25, 2024 •
edited
Loading

mxm_non_aligned might have UB, mxm has fix

Mac M2

Debug

           Name |     Iters | Total time (ns) | Per hash (ns) | Hash rate (1/sec)
=================================================================================
       baseline | 100000000 |       809572583 |             8 |         123521969
        default | 100000000 |      4424295708 |            44 |          22602467
   legacy(djb2) | 100000000 |      2932044583 |            29 |          34105893
            mx3 | 100000000 |      1752195042 |            17 |          57071272
mxm_non_aligned | 100000000 |      1197614625 |            11 |          83499314
            mxm | 100000000 |      1438789500 |            14 |          69502870

RelWithDebInfo

           Name |     Iters | Total time (ns) | Per hash (ns) | Hash rate (1/sec)
=================================================================================
       baseline | 100000000 |        47113000 |             0 |        2122556406
        default | 100000000 |       510100208 |             5 |         196039912
   legacy(djb2) | 100000000 |       329263209 |             3 |         303708392
            mx3 | 100000000 |       183929375 |             1 |         543686945
mxm_non_aligned | 100000000 |        90532959 |             0 |        1104570104
            mxm | 100000000 |       102430959 |             1 |         976267341

GNU/Linux host 3GHz amd64

RelWithDebInfo

           Name |     Iters | Total time (ns) | Per hash (ns) | Hash rate (1/sec)
=================================================================================
       baseline | 100000000 |        42197292 |             0 |        2369820319
        default | 100000000 |       218523883 |             2 |         457615884
   legacy(djb2) | 100000000 |       875467362 |             8 |         114224703
            mx3 | 100000000 |       425392768 |             4 |         235076869
mxm_non_aligned | 100000000 |       210435393 |             2 |         475205233
            mxm | 100000000 |       203974863 |             2 |         490256488

@678098 678098 requested a review from a team as a code owner September 25, 2024 19:06
@678098 678098 requested a review from dorjesinpo September 25, 2024 19:07
bmq-oss-ci[bot]
bmq-oss-ci bot reviewed Sep 25, 2024
View reviewed changes
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 275 of commit 3bf183a has completed with FAILURE

@dorjesinpo dorjesinpo merged commit 136ec3d into main Sep 30, 2024
27 checks passed
@678098 678098 deleted the 678098-patch-4 branch September 30, 2024 22:43
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @dorjesinpo @alexander-e1off
Fix[bmqt_messageguid.h]: fix possible UB due to misalignment (bloombe…
52d5512 
…rg#423)

Signed-off-by: Evgeny Malygin <[email protected]>
Co-authored-by: dorjesinpo <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @dorjesinpo @alexander-e1off
Fix[bmqt_messageguid.h]: fix possible UB due to misalignment (bloombe…
192e371 
…rg#423)

Signed-off-by: Evgeny Malygin <[email protected]>
Co-authored-by: dorjesinpo <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @dorjesinpo @alexander-e1off
Fix[bmqt_messageguid.h]: fix possible UB due to misalignment (bloombe…
038834c 
…rg#423)

Signed-off-by: Evgeny Malygin <[email protected]>
Co-authored-by: dorjesinpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmq-oss-ci bmq-oss-ci[bot] bmq-oss-ci[bot] left review comments

@dorjesinpo dorjesinpo dorjesinpo approved these changes

Assignees

@dorjesinpo dorjesinpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@678098 @dorjesinpo