mqbcfg.xsd: Increase failover timeout to 5 minutes for proxies #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
pniedzielski
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Change to the XSD file looks good.
I was a little confused by the diffs in mqbcfg_messages, but it just looks like the codegen changed where it wants to put definitions/changed to inlining more functions. That's okay with me. CI passes. I just see one place where a version string isn't being outputted; I'm not sure if this is important or not.
| @@ -335,15 +272,15 @@ const int ClusterMonitorConfig::DEFAULT_INITIALIZER_MAX_TIME_MASTER = 120; | |||
|
|
|||
| const int ClusterMonitorConfig::DEFAULT_INITIALIZER_MAX_TIME_NODE = 120; | |||
|
|
|||
| const int ClusterMonitorConfig::DEFAULT_INITIALIZER_MAX_TIME_FAILOVER = 240; | |||
There was a problem hiding this comment.
This is the meat and potatoes. Everything else is noise.
| @@ -6330,12 +5804,12 @@ Configuration::print(bsl::ostream& stream, int level, int spacesPerLevel) const | |||
| } // close package namespace | |||
| } // close enterprise namespace | |||
|
|
|||
| // GENERATED BY BLP_BAS_CODEGEN_2023.10.07 | |||
| // GENERATED BY @BLP_BAS_CODEGEN_VERSION@ | |||
There was a problem hiding this comment.
This looks suspicious.
There was a problem hiding this comment.
I am using the newest version of BAS codegen. For some reason, this string substitution doesn't work but shouldn't be a big deal.
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
…berg#264) Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
…berg#264) Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
…berg#264) Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through the code, I realize that proxies does not use the cluster definitions from
clusters.jsonat all. If you look at the constructor ofClusterProxy, it is passed a default-initializedmqbcfg::ClusterDefinition(allocator). Therefore, it will only use the default values, which is 2 minutes in the case of failover threshold. Therefore, I am raising the default to 5 minutes to make all proxies have a failover timeout of 5 minutes.Clusters nodes obey definitions in
clusters.json, so they should not be affected by this change.