Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use defaultSubQueueInfoArray() #230

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

dorjesinpo
Copy link
Collaborator

Any broadcast PUSH for now needs real subscription id. Cannot use defaultSubQueueInfoArray(), it will cause #CLIENT_INVALID_PUSH or Assertion failed: cit != d_subscriptions.end()

@dorjesinpo dorjesinpo requested a review from a team as a code owner March 29, 2024 00:43
@dorjesinpo dorjesinpo requested a review from kaikulimu March 29, 2024 01:50
@dorjesinpo dorjesinpo added the bug Something isn't working label Mar 29, 2024
Copy link
Collaborator

@kaikulimu kaikulimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dorjesinpo dorjesinpo force-pushed the fix/default-broadcast-ids branch from 26c3dd3 to f4a84b8 Compare April 1, 2024 14:47
@dorjesinpo dorjesinpo merged commit ebffe21 into main Apr 1, 2024
7 checks passed
@678098 678098 deleted the fix/default-broadcast-ids branch April 1, 2024 17:57
syuzvinsky pushed a commit to syuzvinsky/blazingmq that referenced this pull request Apr 4, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants