Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests #173

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Integration tests #173

merged 7 commits into from
Jan 24, 2024

Conversation

jll63
Copy link
Collaborator

@jll63 jll63 commented Dec 15, 2023 •
edited
Loading

  • Some Python modules needed to support the integration test framework.
  • Integration test framework.
  • The integration tests themselves.

@jll63 jll63 requested a review from a team as a code owner December 15, 2023 18:06
@jll63 jll63 marked this pull request as draft December 15, 2023 18:07
@jll63 jll63 force-pushed the it-to-oss branch 5 times, most recently from 13be333 to 28888e7 Compare December 21, 2023 21:23
@jll63 jll63 force-pushed the it-to-oss branch 4 times, most recently from b536e25 to 7e47c07 Compare January 11, 2024 15:26
@jll63 jll63 force-pushed the it-to-oss branch 2 times, most recently from 7e28758 to 3eb6398 Compare January 19, 2024 20:57
@jll63 jll63 marked this pull request as ready for review January 22, 2024 15:00
@jll63 jll63 added the A-Testing Area: Testing label Jan 22, 2024
@jll63 jll63 force-pushed the it-to-oss branch 2 times, most recently from 485055e to bdf3f21 Compare January 23, 2024 17:15
quarter-note
quarter-note reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@quarter-note quarter-note left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

.github/workflows/build.yaml Outdated
/opt/bb/include
key: cache-${{ github.sha }}

build_and_test_bmqprometheus_plugin:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to remove this hook?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. I don't even recall doing this. Restoring...

jll63 added 7 commits January 24, 2024 13:26
@jll63 @quarter-note
Python modules
cfa96d9 
Signed-off-by: Jean-Louis Leroy <[email protected]>
@jll63 @quarter-note
Integration tests
f9ddec3 
Signed-off-by: Jean-Louis Leroy <[email protected]>
@jll63 @quarter-note
rename
6c35980 
Signed-off-by: Jean-Louis Leroy <[email protected]>
@jll63 @quarter-note
simplify
42758a9 
Signed-off-by: Jean-Louis Leroy <[email protected]>
@jll63 @quarter-note
adapt tests
e16c5c1 
Signed-off-by: Jean-Louis Leroy <[email protected]>
@jll63 @quarter-note
workspace -> configurator
dfd4c9b 
Signed-off-by: Jean-Louis Leroy <[email protected]>
@jll63 @quarter-note
build.yaml
735639d 
Signed-off-by: Jean-Louis Leroy <[email protected]>
@quarter-note quarter-note merged commit 3bdaf5a into bloomberg:main Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quarter-note quarter-note quarter-note left review comments

Assignees

@jll63 jll63

Labels
A-Testing Area: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jll63 @quarter-note