Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change C style numeric cast to static_cast #128

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Change C style numeric cast to static_cast #128

merged 4 commits into from
Oct 25, 2023

Conversation

mfrandev
Copy link
Contributor

@mfrandev mfrandev commented Oct 15, 2023 •
edited
Loading

Issue number of the reported bug or feature request: #126

Describe your changes

  1. Change all C style numeric cast statements i.e., (double)val, or int(42), to static_cast<T>(val)

Testing performed
Currently experiencing vcpkg issues, but these changes are safe in nature.

@mfrandev mfrandev requested a review from a team as a code owner October 15, 2023 17:15
@quarter-note quarter-note changed the title bloomberg#126 Change C style numeric cast to static_cast Change C style numeric cast to static_cast Oct 15, 2023
678098
678098 requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some comments

src/groups/mwc/mwcst/mwcst_printutil.cpp Outdated Show resolved Hide resolved
src/groups/mwc/mwcst/mwcst_printutil.cpp Outdated Show resolved Hide resolved
src/groups/mwc/mwcst/mwcst_printutil.cpp Outdated Show resolved Hide resolved
src/groups/mwc/mwcst/mwcst_printutil.cpp Outdated Show resolved Hide resolved
src/groups/mwc/mwcu/mwcu_sharedresource.t.cpp Outdated Show resolved Hide resolved
@mfrandev mfrandev marked this pull request as draft October 19, 2023 14:22
@678098
Copy link
Collaborator

678098 commented Oct 24, 2023

Hi @mfrandev
There are formatting problems left in some files, these could be fixed by launching clang-format -i [path_to_source], like:
clang-format -i src/groups/mwc/mwcst/mwcst_basictableinfoprovider.cpp
Could you fix it?

@mfrandev
Copy link
Contributor Author

mfrandev commented Oct 25, 2023 •
edited
Loading

Hi @678098,

My apologies this hasn't been resolved yet, I've had some issues using vpckg along with a busy week. I have performed formatting changes and updated my branch.

@mfrandev mfrandev marked this pull request as ready for review October 25, 2023 01:51
@mfrandev
Copy link
Contributor Author

I realized that I had forgotten to sign off on last commit, so I have amended it accordingly.

678098
678098 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@678098
Copy link
Collaborator

678098 commented Oct 25, 2023

@mfrandev thank you for your contribution!

@678098 678098 merged commit 08a6d16 into bloomberg:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@678098 678098 678098 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfrandev @678098