Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI build wheel matrix #20

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

pniedzielski
Copy link
Collaborator

This PR fixes some long-running wheel building errors due to cross-compilation, and also adds support for building for all supported versions of Python on all supported platforms.

Our ARM builds for MacOS have been broken on ARM, because the runners
themselves are x86_64, and bde-tools does not properly cross-compile for ARM
builds when run on an x86_64 machine.  This patch disables ARM builds until
there are ARM runners available on GitHub Actions.

Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Because of the cost of MacOS GitHub runners, we did not build wheels for each
supported version of Python on MacOS.  This patch teaches the CI to build a
wheel not just for 3.11, but also for 3.7, 3.8, 3.9, 3.10, and 3.12.

Signed-off-by: Patrick M. Niedzielski <[email protected]>
@pniedzielski pniedzielski added the skip news No news entry is required label Jan 24, 2024
@pniedzielski pniedzielski requested a review from a team as a code owner January 24, 2024 23:00
@pniedzielski pniedzielski requested review from hallfox and removed request for a team January 24, 2024 23:00
@pniedzielski pniedzielski merged commit da69ac6 into bloomberg:main Jan 25, 2024
11 checks passed
@pniedzielski pniedzielski deleted the ci-build-failures branch February 7, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news No news entry is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants