Support Cython 3 where available #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pniedzielski
force-pushed
the
cython3
branch
2 times, most recently
from
5876255 to
85e30f1
Compare
We currently support Python interpreters 3.7 and newer, and Cython 3 supports Python interpreters 3.8 and newer. This patch updates the pip dependencies dependencies to prefer Cython 3 for interpreters 3.8 and newer, keeping the older version of Cython as a dependency for interpreter 3.7. Signed-off-by: Patrick M. Niedzielski <[email protected]>
This patch adds Python 3.7 to our CI build matrix. While we always have supported Python 3.7, it was an oversight not to test builds with it. Crucially, now that we use different Cython versions between 3.7 and our other supported interpreter versions, it is important to check with 3.7 explicitly. Signed-off-by: Patrick M. Niedzielski <[email protected]>
hallfox
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support Python interpreters 3.7 and newer, and Cython 3 supports Python interpreters 3.8 and newer. This patch updates the pip dependencies dependencies to prefer Cython 3 for interpreters 3.8 and newer, keeping the older version of Cython as a dependency for interpreter 3.7.
Closes: #18