FieldValue: Switch to std::variant #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since moving to C++17 we can replace boost::variant with std::variant. Confirmed amqpprox runs OK and the unit tests log a method containing a FieldTable.
willhoy
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since moving to C++17 we can replace boost::variant with std::variant.
Confirmed amqpprox runs OK and the unit tests log a method containing a FieldTable, to excercise the FieldValuePrinter.
I looked into replacing the remaining
boost::shared_ptrusage but sadlyboost::logwon't accept astd::shared_ptr.I also looked into #5 and found this will require a slightly bigger change than just switching the function names.