fix: allow link to open in a new tab if internal #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-ui-seeds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ColinBuyck
approved these changes
Dec 2, 2024
|
🎉 This PR is included in version 1.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Overview
This PR addresses #92
Description
Allows the Link component to also open an internal link in a new window.
How Can This Be Tested/Reviewed?
You can checkout the new link story that has an internal link and also opens in a new window. We can't actually internally link from within Storybook, so it goes expectedly to a Netlify page not found.
Checklist: