Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct ami percentage in csv #4520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Dec 23, 2024

This PR addresses #1027

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The listing units csv export is displaying the incorrect AMI Chart percentage. It is grabbing the first value from the amiChart instead of getting the percentage off of the unit table

Note:

  • There are currently no tests that cover this part of the code and we should add those as a separate issue

How Can This Be Tested/Reviewed?

After a clean reseed In the partner site click the "Export to CSV" button on the listings page and compare the values to the listings

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 946d33d
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/6769d5a4989e400008e61f76
😎 Deploy Preview https://deploy-preview-4520--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 946d33d
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6769d5a4c664ce00087dd925
😎 Deploy Preview https://deploy-preview-4520--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ludtkemorgan ludtkemorgan marked this pull request as ready for review December 24, 2024 18:25
@ludtkemorgan ludtkemorgan added the 1 review needed Requires 1 more review before ready to merge label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 review needed Requires 1 more review before ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant