Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle empty other race options #4513

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Dec 17, 2024

This PR addresses metrotranscom#1009

  • Addresses the issue in full
  • Addresses only certain aspects of the issue
    The ticket also mentions cleaning up the instances where doorway entered a space to get the "other" field to save which this PR doesn't cover.

Description

This PR includes two different empty string checks in the formKeys file which prevents the selection of other without entering further information from being filtered out or being stored with a colon and space.

How Can This Be Tested/Reviewed?

This can be tested by
a) submitting an online app with a mix of demographic data (including other selections without any text inputted) and going to the partners portal to see that it was stored correctly
b) submit a paper app to the same listing with a unique mix of demographic data also including empty other selections and then edit this paper app multiple times to ensure that the selections are saved
c) export the applications to that listing to see that they print in a legible way.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit d1f5142
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/6769c03a6af5400008c2addb
😎 Deploy Preview https://deploy-preview-4513--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit d1f5142
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6769c03a4f490a000895fcca
😎 Deploy Preview https://deploy-preview-4513--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ColinBuyck ColinBuyck marked this pull request as ready for review December 23, 2024 02:29
@ColinBuyck ColinBuyck force-pushed the 1009/other-demographic-saving branch from 033fa51 to ae5799b Compare December 23, 2024 02:31
@ColinBuyck ColinBuyck added the 1 review needed Requires 1 more review before ready to merge label Dec 23, 2024
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and solves the issue.

I did notice that if you use a : within the free text everything after the colon disappears. for example human:alien is saved as human. Looks like that issue also exists in main.

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants