-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle empty other race options #4513
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
033fa51
to
ae5799b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and solves the issue.
I did notice that if you use a :
within the free text everything after the colon disappears. for example human:alien
is saved as human
. Looks like that issue also exists in main.
This PR addresses metrotranscom#1009
The ticket also mentions cleaning up the instances where doorway entered a space to get the "other" field to save which this PR doesn't cover.
Description
This PR includes two different empty string checks in the formKeys file which prevents the selection of other without entering further information from being filtered out or being stored with a colon and space.
How Can This Be Tested/Reviewed?
This can be tested by
a) submitting an online app with a mix of demographic data (including other selections without any text inputted) and going to the partners portal to see that it was stored correctly
b) submit a paper app to the same listing with a unique mix of demographic data also including empty other selections and then edit this paper app multiple times to ensure that the selections are saved
c) export the applications to that listing to see that they print in a legible way.
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: