-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update translations and sign in link for lottery email #4506
base: main
Are you sure you want to change the base?
Conversation
…il for applicants
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Oop deleted my comment after seeing the bottom of the issues attached... do you mind resolving the merge conflicts first? |
@ColinBuyck This should be ready for review now. Thanks! |
translations = await this.prisma.translations.findFirst({ | ||
where: { language, jurisdictionId: null }, | ||
}); | ||
async updateTranslationsForLanguage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: This is all looking good but do you mind sharing more on this refactor? Specifically the changes around findMany? Is this just a code improvement or would the previous helper not work for this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I lost track of this thread! Some of that code is a backport to Core from Doorway, so everything related to translations helpers is now aligned across the two repos. That's the reason for there being more changes than just addressing what's detailed in the issue descriptions.
This PR addresses metrotranscom#959 & metrotranscom#958
Description
The lottery published email for applicants has updated "what happens next" content, and the sign-in button link goes to the Sign In page instead of the homepage.
How Can This Be Tested/Reviewed?
Run the updatesWhatHappensInLotteryEmail script runner endpoint and verify translations are updated.
Not sure the easiest way to test the email, but I added an automated test for that email template.
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: