Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update translations and sign in link for lottery email #4506

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jaredcwhite
Copy link
Collaborator

@jaredcwhite jaredcwhite commented Dec 10, 2024

This PR addresses metrotranscom#959 & metrotranscom#958

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The lottery published email for applicants has updated "what happens next" content, and the sign-in button link goes to the Sign In page instead of the homepage.

How Can This Be Tested/Reviewed?

Run the updatesWhatHappensInLotteryEmail script runner endpoint and verify translations are updated.
Not sure the easiest way to test the email, but I added an automated test for that email template.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 3ae97a9
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/6786c3c1dcc8c50008e7169a
😎 Deploy Preview https://deploy-preview-4506--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 3ae97a9
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6786c3c1fd224c00086dc85b
😎 Deploy Preview https://deploy-preview-4506--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaredcwhite jaredcwhite added the 1 review needed Requires 1 more review before ready to merge label Dec 10, 2024
@ColinBuyck
Copy link
Collaborator

Oop deleted my comment after seeing the bottom of the issues attached... do you mind resolving the merge conflicts first?

@jaredcwhite
Copy link
Collaborator Author

@ColinBuyck This should be ready for review now. Thanks!

translations = await this.prisma.translations.findFirst({
where: { language, jurisdictionId: null },
});
async updateTranslationsForLanguage(
Copy link
Collaborator

@ColinBuyck ColinBuyck Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: This is all looking good but do you mind sharing more on this refactor? Specifically the changes around findMany? Is this just a code improvement or would the previous helper not work for this case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I lost track of this thread! Some of that code is a backport to Core from Doorway, so everything related to translations helpers is now aligned across the two repos. That's the reason for there being more changes than just addressing what's detailed in the issue descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 review needed Requires 1 more review before ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants