-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable utilities and accessibility features #4503
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f66a0d2
to
30ff13a
Compare
30ff13a
to
e23e3e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, one small 🧹
api/prisma/migrations/23_remove_jurisdiction_enable_fields/migration.sql
Outdated
Show resolved
Hide resolved
c72d63a
to
de344fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: signed in as an admin, I can still see the sections for a listing for another jurisdiction on creation
Screen.Recording.2025-01-07.at.3.22.30.PM.mov
api/prisma/migrations/23_remove_jurisdiction_enable_fields/migration.sql
Outdated
Show resolved
Hide resolved
@mcgarrye good catch. I was missing an |
@emilyjablonski There is no design for this as these fields already existed in both public and partners, there was just some bugs with the saving of the values. So the design is the same as when it was implemented 3 years ago. Looks like that styling is coming from a ui-components component |
c9c72c9
to
e29c046
Compare
e29c046
to
dddeeae
Compare
sites/partners/src/components/listings/PaperListingDetails/sections/DetailUnits.tsx
Show resolved
Hide resolved
@ludtkemorgan I'm about to rewrite that section, so it's no worries to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐧
f3c3497
to
665f639
Compare
665f639
to
28bc43b
Compare
This PR addresses #4440 #4439
Description
Listing utilities and accessibility features functionality already exist. However it was not working correctly. This PR fixes all of the bugs as well as connecting it to the new feature flag functionality
NOTE: the jurisdiction table fields have also been removed since we can now use the feature flag table
How Can This Be Tested/Reviewed?
Both feature flags are added to the staging seeded data for "Bloomington" jurisdiction so the following can be tested with a new reseed
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: