fix: switch to HTML text inputs with numeric validation #4128
+43
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Cypress test failing seems to just be a glitch |
jaredcwhite
added
the
1 review needed
| @@ -700,10 +700,10 @@ const PreferenceDrawer = ({ | |||
| name="radiusSize" | |||
| label={t("settings.preferenceValidatingAddress.howManyMiles")} | |||
| register={register} | |||
| validation={{ required: true, min: 0 }} | |||
| validation={{ required: true, min: 0, pattern: /^[0-9.]+$/ }} | |||
There was a problem hiding this comment.
What might min do here now that it's text?
emilyjablonski
requested changes
Jun 12, 2024
emilyjablonski
added
needs changes
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jaredcwhite
force-pushed
the
658/text-inputs-with-validation
branch
from
597b000 to
68c56f0
Compare
jaredcwhite
added
1 review needed
|
I've updated the PR with a combination of currency-specific fields and text fields with numeric validation. Only the currency fields expressively forbid typing letters, and they also have the byproduct of forcing decimal places (aka |
emilyjablonski
added
on hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses metrotranscom#658
Description
Note: see comment below
The working theory is the issue with numbers changing randomly in the unit editing is due to
input type="number"weirdness around mouse/trackpad scrolling. This PR switches toinput type="text"and uses React Hook Form validation to verify integer input.How Can This Be Tested/Reviewed?
Try editing units for a listing, income, or the miles radius on preferences.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: