-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add preview check #4126
base: main
Are you sure you want to change the base?
fix: add preview check #4126
Conversation
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected! though personally don't love this change but whatcha gonna do. LGTM
Yeahhh, I feel you @mcgarrye. I'm going to double check with Product and Design before merging and pulling this over. |
@@ -626,7 +626,7 @@ export const ListingView = (props: ListingProps) => { | |||
{!applicationsClosed && getWaitlist()} | |||
{hasNonReferralMethods && | |||
!applicationsClosed && | |||
listing.status !== ListingsStatusEnum.closed ? ( | |||
(listing.status !== ListingsStatusEnum.closed || props.preview) ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this still have the issue of if they are trying to reopen a listing that the application due date is in the past? I guess they shouldn't be publishing a listing like that, but they might want to still preview it. And even in that case an easy fix for them would to update the application due date to something in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will still have that behavior but my thought was that it wouldn't be an issue because it is representing what the listing would show when published. I know some admin use preview as a final "does everything look good" check and I think I'd prefer a closed application flagged to them then.
This PR addresses #668
Description
This logic update allows for partner users to see the application section of the listing detail page if they're in preview mode.
How Can This Be Tested/Reviewed?
Run locally, close a listing, make changes to that listing (ie. add a paper application), ensure those updates are reflected when you preview that closed listing.
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: