Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address various design QA for buttons #4118

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

jaredcwhite
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses bloom-housing/ui-seeds#72

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

There are 5 pieces of feedback in the issue, this PR addresses 1, 2, and 4.
3 & 5 have been addressed separately in #4084

How Can This Be Tested/Reviewed?

Sign into the Partners app and verify the revised button sizes and placements as described in the issue.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@jaredcwhite jaredcwhite added the 1 review needed Requires 1 more review before ready to merge label Jun 4, 2024
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 2665f73
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/665e8632560c2e00088e4965
😎 Deploy Preview https://deploy-preview-4118--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🖌️

@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 6, 2024
@jaredcwhite jaredcwhite merged commit 0d5f01b into main Jun 11, 2024
20 checks passed
jaredcwhite added a commit to housingbayarea/bloom that referenced this pull request Jun 12, 2024
jaredcwhite added a commit to metrotranscom/doorway that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants