fix: user update/create fixes (#3932)

bloom-housing · Mar 7, 2024 · fcb3631 · fcb3631
1 parent 5662226
commit fcb3631
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/api/src/services/user.service.ts b/api/src/services/user.service.ts
@@ -197,6 +197,7 @@ export class UserService {
     // only update userRoles if something has changed
     if (dto.userRoles && storedUser.userRoles) {
       if (
+        requestingUser.userRoles.isAdmin &&
         !(
           dto.userRoles.isAdmin === storedUser.userRoles.isAdmin &&
           dto.userRoles.isJurisdictionalAdmin ===
@@ -551,11 +552,6 @@ export class UserService {
             listings: {
               connect: listings.map((listing) => ({ id: listing.id })),
             },
-            userRoles: {
-              create: {
-                ...dto.userRoles,
-              },
-            },
           },
           where: {
             id: existingUser.id,