feat: spreadsheetification of lottery export (#4228)

* feat: spreadsheetification of lottery export * fix: updates for tests * fix: updates per pr comments * fix: adding test for coverage * fix: removes un ranked applications from export
bloom-housing · Aug 1, 2024 · fb23902 · fb23902
1 parent add7aff
commit fb23902
Show file tree

Hide file tree

Showing 16 changed files with 1,907 additions and 1,226 deletions.
diff --git a/api/package.json b/api/package.json
@@ -60,6 +60,7 @@
     "compression": "^1.7.4",
     "cookie-parser": "~1.4.6",
     "dayjs": "~1.11.9",
+    "exceljs": "^4.4.0",
     "handlebars": "~4.7.8",
     "jsonwebtoken": "~9.0.1",
     "lodash": "~4.17.21",
@@ -80,6 +81,7 @@
     "@nestjs/schematics": "^10.1.1",
     "@nestjs/testing": "^10.3.2",
     "@types/compression": "^1.7.5",
+    "@types/exceljs": "1.3.0",
     "@types/express": "~4.17.17",
     "@types/jest": "~29.5.3",
     "@types/node": "^18.7.14",

diff --git a/api/src/controllers/application.controller.ts b/api/src/controllers/application.controller.ts
@@ -95,26 +95,6 @@ export class ApplicationController {
     return await this.applicationService.mostRecentlyCreated(queryParams, req);
   }
 
-  @Get(`getLotteryResults`)
-  @ApiOperation({
-    summary: 'Get applications lottery results',
-    operationId: 'lotteryResults',
-  })
-  @Header('Content-Type', 'text/csv')
-  @UseInterceptors(ExportLogInterceptor)
-  async lotteryExport(
-    @Request() req: ExpressRequest,
-    @Res({ passthrough: true }) res: Response,
-    @Query(new ValidationPipe(defaultValidationPipeOptions))
-    queryParams: ApplicationCsvQueryParams,
-  ): Promise<StreamableFile> {
-    return await this.applicationCsvExportService.lotteryExport(
-      req,
-      res,
-      queryParams,
-    );
-  }
-
   @Get(`csv`)
   @ApiOperation({
     summary: 'Get applications as csv',

diff --git a/api/src/controllers/lottery.controller.ts b/api/src/controllers/lottery.controller.ts
@@ -1,10 +1,13 @@
 import {
   Body,
   Controller,
+  Get,
   Header,
   Put,
+  Query,
   Request,
   Res,
+  StreamableFile,
   UseGuards,
   UseInterceptors,
   UsePipes,
@@ -36,7 +39,6 @@ export class LotteryController {
     summary: 'Generate the lottery results for a listing',
     operationId: 'lotteryGenerate',
   })
-  @Header('Content-Type', 'text/csv')
   @UseInterceptors(ExportLogInterceptor)
   async lotteryGenerate(
     @Request() req: ExpressRequest,
@@ -45,4 +47,20 @@ export class LotteryController {
   ): Promise<SuccessDTO> {
     return await this.lotteryService.lotteryGenerate(req, res, queryParams);
   }
+
+  @Get(`getLotteryResults`)
+  @ApiOperation({
+    summary: 'Get applications lottery results',
+    operationId: 'lotteryResults',
+  })
+  @Header('Content-Type', 'application/zip')
+  @UseInterceptors(ExportLogInterceptor)
+  async lotteryExport(
+    @Request() req: ExpressRequest,
+    @Res({ passthrough: true }) res: Response,
+    @Query(new ValidationPipe(defaultValidationPipeOptions))
+    queryParams: ApplicationCsvQueryParams,
+  ): Promise<StreamableFile> {
+    return await this.lotteryService.lotteryExport(req, res, queryParams);
+  }
 }